linux-kernel - [PATCH] [RFC] get_maintainer: Really limit regex patterns to words

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190617142320.2830-1-geert+renesas@glider.be>
Date:   Mon, 17 Jun 2019 16:23:20 +0200
From:   Geert Uytterhoeven <geert+renesas@...der.be>
To:     Joe Perches <joe@...ches.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>
Cc:     linux-stm32@...md-mailman.stormreply.com,
        linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: [PATCH] [RFC] get_maintainer: Really limit regex patterns to words

Limit file and directory regex matching to paths that contain the
pattern as a word, i.e. that contain word boundaries before and after
the pattern.  This helps avoiding false positives.

Without this, e.g. "scripts/get_maintainer.pl -f
tools/perf/pmu-events/arch/x86/westmereex" lists the STM32 maintainers,
due to the presence of "stm" in the middle of a word in the path name.

Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
---
What to do with drivers/pwm/pwm-stmpe.c, which is no longer caught?
Add a new pattern to MAINTAINERS?
---
 scripts/get_maintainer.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index c1c088ef1420e68a..a34057d87a56492f 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -884,7 +884,7 @@ sub get_maintainers {
 				}
 			    }
 			} elsif ($type eq 'N') {
-			    if ($file =~ m/$value/x) {
+			    if ($file =~ m/\b$value\b/x) {
 				$hash{$tvi} = 0;
 			    }
 			}
-- 
2.17.1