linux-kernel - Re: [PATCH] [RFC] get_maintainer: Really limit regex patterns to words

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f241554ff74531d3a61e6bd1c1043831e870819.camel@perches.com>
Date:   Mon, 17 Jun 2019 09:17:39 -0700
From:   Joe Perches <joe@...ches.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>
Cc:     linux-stm32@...md-mailman.stormreply.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC] get_maintainer: Really limit regex patterns to
 words

On Mon, 2019-06-17 at 16:23 +0200, Geert Uytterhoeven wrote:
> Limit file and directory regex matching to paths that contain the
> pattern as a word, i.e. that contain word boundaries before and after
> the pattern.  This helps avoiding false positives.
> 
> Without this, e.g. "scripts/get_maintainer.pl -f
> tools/perf/pmu-events/arch/x86/westmereex" lists the STM32 maintainers,
> due to the presence of "stm" in the middle of a word in the path name.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> What to do with drivers/pwm/pwm-stmpe.c, which is no longer caught?
> Add a new pattern to MAINTAINERS?

Hi Geert

> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> @@ -884,7 +884,7 @@ sub get_maintainers {
>  				}
>  			    }
>  			} elsif ($type eq 'N') {
> -			    if ($file =~ m/$value/x) {
> +			    if ($file =~ m/\b$value\b/x) {

I'm not sure this is the right approach as it also
affects regexes like
"N:	rockchip" where there
are multiple current matches that wouldn't
work anymore.

It might be better to change the regexes in MAINTAINERS
where appropriate.

There is also a regex with a directory slash so it's
probably better to use m{<foo>}

MAINTAINERS:N:  /pmac