linux-kernel - Re: [PATCH 3/4] regulator: Add regulator driver for ATC260x PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a38d26d1-213c-31ef-9cc7-1d4bdda4ceab@suse.de>
Date:   Mon, 17 Jun 2019 18:38:53 +0200
From:   Andreas Färber <afaerber@...e.de>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Mark Brown <broonie@...nel.org>
Cc:     lee.jones@...aro.org, lgirdwood@...il.com, robh+dt@...nel.org,
        linux-actions@...ts.infradead.org, linux-kernel@...r.kernel.org,
        thomas.liau@...ions-semi.com, devicetree@...r.kernel.org,
        linus.walleij@...aro.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 3/4] regulator: Add regulator driver for ATC260x PMICs

Hi,

Am 17.06.19 um 18:34 schrieb Manivannan Sadhasivam:
> On Mon, Jun 17, 2019 at 05:30:15PM +0100, Mark Brown wrote:
>> On Mon, Jun 17, 2019 at 09:20:10PM +0530, Manivannan Sadhasivam wrote:
>>
>>> +++ b/drivers/regulator/atc260x-regulator.c
>>> @@ -0,0 +1,389 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/*
>>> + * Regulator driver for ATC260x PMICs
>>
>> Please make the entire comment a C++ one so this looks more intentional.

No, this is intentional and the official style requested by GregKH.

He suggested I patch the SPDX documentation to make this clearer, but I
did not find time for this yet (and am not the one making this rule).

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)