linux-kernel - Re: [PATCH 3/4] regulator: Add regulator driver for ATC260x PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190617165400.GE5316@sirena.org.uk>
Date:   Mon, 17 Jun 2019 17:54:00 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Andreas Färber <afaerber@...e.de>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        lee.jones@...aro.org, lgirdwood@...il.com, robh+dt@...nel.org,
        linux-actions@...ts.infradead.org, linux-kernel@...r.kernel.org,
        thomas.liau@...ions-semi.com, devicetree@...r.kernel.org,
        linus.walleij@...aro.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 3/4] regulator: Add regulator driver for ATC260x PMICs

On Mon, Jun 17, 2019 at 06:38:53PM +0200, Andreas Färber wrote:
> Am 17.06.19 um 18:34 schrieb Manivannan Sadhasivam:
> > On Mon, Jun 17, 2019 at 05:30:15PM +0100, Mark Brown wrote:

> >>> @@ -0,0 +1,389 @@
> >>> +// SPDX-License-Identifier: GPL-2.0+
> >>> +/*
> >>> + * Regulator driver for ATC260x PMICs

> >> Please make the entire comment a C++ one so this looks more intentional.

> No, this is intentional and the official style requested by GregKH.

The important bit for the tools is the first line, the rest of it the
tools don't care about.

> He suggested I patch the SPDX documentation to make this clearer, but I
> did not find time for this yet (and am not the one making this rule).

The other regulator API files are all the way I suggest...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)