linux-kernel - Re: [PATCH 1/2] mfd: mt6397: Use PLATFORM_DEVID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jun 2019 23:16:01 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Fabien Parent <fparent@...libre.com>, lee.jones@...aro.org
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mfd: mt6397: Use PLATFORM_DEVID_NONE macro instead of
 -1



On 18/06/2019 17:43, Fabien Parent wrote:
> Use the correct macro when adding the MFD devices instead of using
> directly '-1' value.
> 
> Signed-off-by: Fabien Parent <fparent@...libre.com>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
>  drivers/mfd/mt6397-core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 337bcccdb914..190ed86ad93e 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -299,9 +299,9 @@ static int mt6397_probe(struct platform_device *pdev)
>  		if (ret)
>  			return ret;
>  
> -		ret = devm_mfd_add_devices(&pdev->dev, -1, mt6323_devs,
> -					   ARRAY_SIZE(mt6323_devs), NULL,
> -					   0, pmic->irq_domain);
> +		ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
> +					   mt6323_devs, ARRAY_SIZE(mt6323_devs),
> +					   NULL, 0, pmic->irq_domain);
>  		break;
>  
>  	case MT6397_CID_CODE:
> @@ -314,9 +314,9 @@ static int mt6397_probe(struct platform_device *pdev)
>  		if (ret)
>  			return ret;
>  
> -		ret = devm_mfd_add_devices(&pdev->dev, -1, mt6397_devs,
> -					   ARRAY_SIZE(mt6397_devs), NULL,
> -					   0, pmic->irq_domain);
> +		ret = devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
> +					   mt6397_devs, ARRAY_SIZE(mt6397_devs),
> +					   NULL, 0, pmic->irq_domain);
>  		break;
>  
>  	default:
>