linux-kernel - Re: [PATCH 2/2] mfd: mt6397: use DEFINE_RES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6bf2d5a0-a768-b178-80c7-4f28f7db212c@gmail.com>
Date:   Tue, 18 Jun 2019 23:18:44 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Fabien Parent <fparent@...libre.com>, lee.jones@...aro.org
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mfd: mt6397: use DEFINE_RES_* helpers to define RTC
 resources



On 18/06/2019 17:43, Fabien Parent wrote:
> Use the DEFINE_RES_{MEM,IRQ} to define the RTC reosurce for the MT6397
> PMIC.
> 
> Signed-off-by: Fabien Parent <fparent@...libre.com>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
>  drivers/mfd/mt6397-core.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 190ed86ad93e..1e315712870b 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -23,16 +23,8 @@
>  #define MT6397_CID_CODE		0x97
>  
>  static const struct resource mt6397_rtc_resources[] = {
> -	{
> -		.start = MT6397_RTC_BASE,
> -		.end   = MT6397_RTC_BASE + MT6397_RTC_SIZE,
> -		.flags = IORESOURCE_MEM,
> -	},
> -	{
> -		.start = MT6397_IRQ_RTC,
> -		.end   = MT6397_IRQ_RTC,
> -		.flags = IORESOURCE_IRQ,
> -	},
> +	DEFINE_RES_MEM(MT6397_RTC_BASE, MT6397_RTC_SIZE),
> +	DEFINE_RES_IRQ(MT6397_IRQ_RTC),
>  };
>  
>  static const struct resource mt6323_keys_resources[] = {
>