linux-kernel - Re: [PATCH] usb: gadget: udc: lpc32xx: allocate descriptor with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tvcnffiu.fsf@linux.intel.com>
Date:   Tue, 18 Jun 2019 11:45:29 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Vladimir Zapolskiy <vz@...ia.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sylvain Lemieux <slemieux.tyco@...il.com>,
        James Grant <james.grant@....com>, linux-usb@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: udc: lpc32xx: allocate descriptor with GFP_ATOMIC


Hi,

Alexandre Belloni <alexandre.belloni@...tlin.com> writes:
> Hi,
>
> On 18/06/2019 10:33:41+0300, Felipe Balbi wrote:
>> Alexandre Belloni <alexandre.belloni@...tlin.com> writes:
>> 
>> > Gadget drivers may queue request in interrupt context. This would lead to
>> > a descriptor allocation in that context. In that case we would hit
>> > BUG_ON(in_interrupt()) in __get_vm_area_node.
>> >
>> > Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
>> > ---
>> >  drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
>> > index d8f1c60793ed..b706d9c85a35 100644
>> > --- a/drivers/usb/gadget/udc/lpc32xx_udc.c
>> > +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
>> > @@ -938,7 +938,7 @@ static struct lpc32xx_usbd_dd_gad *udc_dd_alloc(struct lpc32xx_udc *udc)
>> >  	struct lpc32xx_usbd_dd_gad	*dd;
>> >  
>> >  	dd = (struct lpc32xx_usbd_dd_gad *) dma_pool_alloc(
>> > -			udc->dd_cache, (GFP_KERNEL | GFP_DMA), &dma);
>> > +			udc->dd_cache, (GFP_ATOMIC | GFP_DMA), &dma);
>> 
>> doesn't apply:
>> 
>> checking file drivers/usb/gadget/udc/lpc32xx_udc.c
>> Hunk #1 FAILED at 938.
>> 
>
> You already applied it for v5.2-rc5

d'oh!

Guess I haven't looked at my inbox in a while :-p

thanks

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)