linux-kernel - Re: [PATCH] media: pvrusb2: use a different format for warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190619114458.52474694@coco.lan>
Date:   Wed, 19 Jun 2019 11:44:58 -0300
From:   Mauro Carvalho Chehab <mchehab@...nel.org>
To:     Andrey Konovalov <andreyknvl@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        USB list <linux-usb@...r.kernel.org>,
        linux-media@...r.kernel.org,
        Alan Stern <stern@...land.harvard.edu>,
        Mike Isely <isely@...ox.com>,
        LKML <linux-kernel@...r.kernel.org>,
        syzbot <syzbot+af8f8d2ac0d39b0ed3a0@...kaller.appspotmail.com>,
        syzbot <syzbot+170a86bf206dd2c6217e@...kaller.appspotmail.com>
Subject: Re: [PATCH] media: pvrusb2: use a different format for warnings

Em Wed, 19 Jun 2019 16:30:01 +0200
Andrey Konovalov <andreyknvl@...gle.com> escreveu:

> On Thu, May 2, 2019 at 6:39 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > On Thu, May 02, 2019 at 06:09:26PM +0200, Andrey Konovalov wrote:  
> > > When the pvrusb2 driver detects that there's something wrong with the
> > > device, it prints a warning message. Right now those message are
> > > printed in two different formats:
> > >
> > > 1. ***WARNING*** message here
> > > 2. WARNING: message here
> > >
> > > There's an issue with the second format. Syzkaller recognizes it as a
> > > message produced by a WARN_ON(), which is used to indicate a bug in the
> > > kernel. However pvrusb2 prints those warnings to indicate an issue with
> > > the device, not the bug in the kernel.
> > >
> > > This patch changes the pvrusb2 driver to consistently use the first
> > > warning message format. This will unblock syzkaller testing of this
> > > driver.
> > >
> > > Reported-by: syzbot+af8f8d2ac0d39b0ed3a0@...kaller.appspotmail.com
> > > Reported-by: syzbot+170a86bf206dd2c6217e@...kaller.appspotmail.com
> > > Signed-off-by: Andrey Konovalov <andreyknvl@...gle.com>  
> >
> > Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>  
> 
> I don't think I see this patch picked up anywhere. Should this fix go
> through the USB or some media tree?

Media drivers go via the media tree. You should notice that we are
currently receiving around 100 patches per week there. It may take
some time for people to review, but the patches are queued at
patchwork, so sooner or later someone will review and apply, if nobody
did it already:

	https://patchwork.linuxtv.org/project/linux-media/list/

That's said, I'm not seeing this patch there:

	https://patchwork.linuxtv.org/project/linux-media/list/?series=&submitter=&state=*&q=pvrusb2&archive=&delegate=

It sounds that, for whatever reason, the patch never arrived
patchwork. Please re-submit it and check if media patchwork got it.

If not, perhaps you just found a bug with patchwork 2.1 :-)
(we upgraded from version 1.0 to 2.1 at the beginning of this
month)
Thanks,
Mauro