linux-kernel - Re: [PATCH v2 2/3] jbd2: introduce jbd2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190620212517.GC4650@mit.edu>
Date:   Thu, 20 Jun 2019 17:25:17 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Ross Zwisler <zwisler@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Ross Zwisler <zwisler@...gle.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Jan Kara <jack@...e.com>, linux-ext4@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        Fletcher Woodruff <fletcherw@...gle.com>,
        Justin TerAvest <teravest@...gle.com>, Jan Kara <jack@...e.cz>,
        stable@...r.kernel.org
Subject: Re: [PATCH v2 2/3] jbd2: introduce jbd2_inode dirty range scoping

On Thu, Jun 20, 2019 at 09:18:38AM -0600, Ross Zwisler wrote:
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 5c04181b7c6d8..0e0393e7f41a4 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -1397,6 +1413,12 @@ extern int	   jbd2_journal_force_commit(journal_t *);
>  extern int	   jbd2_journal_force_commit_nested(journal_t *);
>  extern int	   jbd2_journal_inode_add_write(handle_t *handle, struct jbd2_inode *inode);
>  extern int	   jbd2_journal_inode_add_wait(handle_t *handle, struct jbd2_inode *inode);
> +extern int	   jbd2_journal_inode_ranged_write(handle_t *handle,
> +			struct jbd2_inode *inode, loff_t start_byte,
> +			loff_t length);
> +extern int	   jbd2_journal_inode_ranged_wait(handle_t *handle,
> +			struct jbd2_inode *inode, loff_t start_byte,
> +			loff_t length);
>  extern int	   jbd2_journal_begin_ordered_truncate(journal_t *journal,
>  				struct jbd2_inode *inode, loff_t new_size);
>  extern void	   jbd2_journal_init_jbd_inode(struct jbd2_inode *jinode, struct inode *inode);

You're adding two new functions that are called from outside the jbd2
subsystem.  To support compiling jbd2 as a module, we also need to add
EXPORT_SYMBOL declarations for these two functions.

I'll take care of this when applying this change.

Thanks, applied.

    		     	       	       - Ted