linux-kernel - Re: [PATCH 0/2] Fix misuse of blk_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <054f3ab6-0a03-ff0e-ac46-5d0fba012cf0@gmail.com>
Date:   Thu, 20 Jun 2019 20:18:55 +0300
From:   Pavel Begunkov <asml.silence@...il.com>
To:     Josef Bacik <josef@...icpanda.com>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, dennis@...nel.org
Subject: Re: [PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency

Hi,

Josef, thanks for taking a look.


Although, there is nothing critical yet -- just a not working / disabled
optimisation, but changes in stats could sublty break it. E.g. grouping
@batch and @mean into a union will increase estimated average by several
orders of magnitude.

Jens, what do you think?



On 14/06/2019 16:40, Josef Bacik wrote:
> On Fri, Jun 14, 2019 at 02:44:11PM +0300, Pavel Begunkov (Silence) wrote:
>> From: Pavel Begunkov <asml.silence@...il.com>
>>
>> There are implicit assumptions about struct blk_rq_stats, which make
>> it's very easy to misuse. The first patch fixes consequences, and the
>> second employs type-system to prevent recurrences.
>>
>>
>> Pavel Begunkov (2):
>>   blk-iolatency: Fix zero mean in previous stats
>>   blk-stats: Introduce explicit stat staging buffers
>>
> 
> I don't have a problem with this, but it's up to Jens I suppose
> 
> Acked-by: Josef Bacik <josef@...icpanda.com>
> 
> Thanks,
> 
> Josef
> 

-- 
Yours sincerely,
Pavel Begunkov



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)