linux-kernel - Re: [PATCH 1/3] timekeeping: add missing non-

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a14=isYJFZYZ5BGGPQY0eLCA7zswHTt=F7Yd4kN-8EtrA@mail.gmail.com>
Date:   Fri, 21 Jun 2019 16:29:06 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/3] timekeeping: add missing non-_ns functions for fast accessors

On Thu, Jun 20, 2019 at 4:12 PM Jason A. Donenfeld <Jason@...c4.com> wrote:
>
> Previously there was no analogue to get proper ktime_t versions of the
> fast variety of ktime invocations. This commit makes the interface
> uniform with the other accessors.
>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Thomas Gleixner <tglx@...utronix.de>

Consistent is good, not sure if there is a real use for the *_fast()
functions returning a ktime_t, but I don't mind adding them.

> +.. c:function:: ktime_t ktime_get_mono_fast_ns( void )
> +               ktime_t ktime_get_raw_fast_ns( void )
> +               ktime_t ktime_get_boottime_fast_ns( void )
> +               ktime_t ktime_get_real_fast_ns( void )
> +
>  .. c:function:: u64 ktime_get_mono_fast_ns( void )
>                 u64 ktime_get_raw_fast_ns( void )
>                 u64 ktime_get_boot_fast_ns( void )

Typo: you have the same function names listed twice here,
one of them should be ktime_get_mono_fast() instead of
ktime_get_mono_fast_ns().

Also, we might want to rename ktime_get_boot_fast_ns()
to ktime_get_boottime_fast_ns in the process. It seems there
is only a single caller.

      Arnd