linux-kernel - Re: [PATCH v2 13/28] drivers: Introduce class_find_device_by_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <325e46fd-a480-78ed-81fd-55e993fbc06f@axentia.se>
Date:   Sat, 22 Jun 2019 05:25:54 +0000
From:   Peter Rosin <peda@...ntia.se>
To:     Suzuki K Poulose <suzuki.poulose@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        Alan Tull <atull@...nel.org>, Moritz Fischer <mdf@...nel.org>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jiri Slaby <jslaby@...e.com>
Subject: Re: [PATCH v2 13/28] drivers: Introduce
 class_find_device_by_of_node() helper

On 2019-06-14 19:54, Suzuki K Poulose wrote:
> Add a wrapper to class_find_device() to search for a device
> by the of_node pointer, reusing the generic match function.
> Also convert the existing users to make use of the new helper.
> 
> Cc: Alan Tull <atull@...nel.org>
> Cc: Moritz Fischer <mdf@...nel.org>
> Cc: linux-fpga@...r.kernel.org
> Cc: Peter Rosin <peda@...ntia.se>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Heiner Kallweit <hkallweit1@...il.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Liam Girdwood <lgirdwood@...il.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Jiri Slaby <jslaby@...e.com>
> Acked-by: Mark Brown <broonie@...nel.org>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Reviewed-by: Peter Rosin <peda@...ntia.se>

Whoooa! I reviewed only the drivers/mux/core.c changes when this was done
in a series of much smaller patches. This tag makes it seem as if I have
reviewed the whole thing, which I had not done when you added this tag out
of the blue.

Now, this stuff is trivial and by now I have looked at the other files
and it all seems simple enough. So, you can keep the tag, but it is NOT
ok to handle tags like you have done here.

Cheers,
Peter

> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
> ---
>  drivers/fpga/fpga-bridge.c       |  8 +-------
>  drivers/fpga/fpga-mgr.c          |  8 +-------
>  drivers/mux/core.c               |  7 +------
>  drivers/net/phy/mdio_bus.c       |  9 +--------
>  drivers/regulator/of_regulator.c |  7 +------
>  drivers/spi/spi.c                | 11 ++---------
>  include/linux/device.h           | 12 ++++++++++++
>  7 files changed, 19 insertions(+), 43 deletions(-)