linux-kernel - Re: [PATCH v2 13/28] drivers: Introduce class_find_device_by_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cf1a8e2-bb1e-b6bc-32fe-93db0a6b5efd@arm.com>
Date:   Mon, 24 Jun 2019 09:34:42 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     peda@...ntia.se, linux-kernel@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, rafael@...nel.org, atull@...nel.org,
        mdf@...nel.org, linux-fpga@...r.kernel.org, broonie@...nel.org,
        f.fainelli@...il.com, hkallweit1@...il.com, davem@...emloft.net,
        andrew@...n.ch, lgirdwood@...il.com, jslaby@...e.com
Subject: Re: [PATCH v2 13/28] drivers: Introduce
 class_find_device_by_of_node() helper

Hi Peter,

On 22/06/2019 06:25, Peter Rosin wrote:
> On 2019-06-14 19:54, Suzuki K Poulose wrote:
>> Add a wrapper to class_find_device() to search for a device
>> by the of_node pointer, reusing the generic match function.
>> Also convert the existing users to make use of the new helper.
>>
>> Cc: Alan Tull <atull@...nel.org>
>> Cc: Moritz Fischer <mdf@...nel.org>
>> Cc: linux-fpga@...r.kernel.org
>> Cc: Peter Rosin <peda@...ntia.se>
>> Cc: Mark Brown <broonie@...nel.org>
>> Cc: Florian Fainelli <f.fainelli@...il.com>
>> Cc: Heiner Kallweit <hkallweit1@...il.com>
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: Andrew Lunn <andrew@...n.ch>
>> Cc: Liam Girdwood <lgirdwood@...il.com>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
>> Cc: Jiri Slaby <jslaby@...e.com>
>> Acked-by: Mark Brown <broonie@...nel.org>
>> Reviewed-by: Andrew Lunn <andrew@...n.ch>
>> Reviewed-by: Peter Rosin <peda@...ntia.se>
> 
> Whoooa! I reviewed only the drivers/mux/core.c changes when this was done
> in a series of much smaller patches. This tag makes it seem as if I have
> reviewed the whole thing, which I had not done when you added this tag out
> of the blue.

Apologies for the surprise. The patch was simply squashed with the change that
introduced the "helper" to better aid the reviewers, based on suggestions on the
list. I kept your tags, only because there were no changes, but some additional
context on the core driver.

> 
> Now, this stuff is trivial and by now I have looked at the other files
> and it all seems simple enough. So, you can keep the tag, but it is NOT
> ok to handle tags like you have done here.

Sure, I will keep that in mind.

Cheers
Suzuki