linux-kernel - Re: [PATCH BUGFIX 1/1] block, bfq: fix operator in BFQQ_TOTALLY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 22 Jun 2019 22:42:48 +0200
From:   Paolo Valente <paolo.valente@...aro.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     linux-block <linux-block@...r.kernel.org>,
        linux-kernel@...r.kernel.org, ulf.hansson@...aro.org,
        linus.walleij@...aro.org, bfq-iosched@...glegroups.com,
        oleksandr@...alenko.name
Subject: Re: [PATCH BUGFIX 1/1] block, bfq: fix operator in BFQQ_TOTALLY_SEEKY

Sorry, I forgot to mention the fixed commit. Making a V2 ...

> Il giorno 22 giu 2019, alle ore 21:38, Paolo Valente <paolo.valente@...aro.org> ha scritto:
> 
> By mistake, there is a '&' instead of a '==' in the definition of the
> macro BFQQ_TOTALLY_SEEKY. This commit replaces the wrong operator with
> the correct one.
> 
> Signed-off-by: Paolo Valente <paolo.valente@...aro.org>
> ---
> block/bfq-iosched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index f8d430f88d25..f9269ae6da9c 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -240,7 +240,7 @@ static struct kmem_cache *bfq_pool;
>  * containing only random (seeky) I/O are prevented from being tagged
>  * as soft real-time.
>  */
> -#define BFQQ_TOTALLY_SEEKY(bfqq)	(bfqq->seek_history & -1)
> +#define BFQQ_TOTALLY_SEEKY(bfqq)	(bfqq->seek_history == -1)
> 
> /* Min number of samples required to perform peak-rate update */
> #define BFQ_RATE_MIN_SAMPLES	32
> -- 
> 2.20.1
>