linux-kernel - Re: [PATCH v6] mfd: cros_ec_dev: Register cros_ec_accel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190624135822.GH4699@dell>
Date:   Mon, 24 Jun 2019 14:58:22 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Gwendal Grignou <gwendal@...omium.org>
Cc:     bleung@...omium.org, enric.balletbo@...labora.com,
        groeck@...omium.org, linux-kernel@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v6] mfd: cros_ec_dev: Register cros_ec_accel_legacy
 driver as a subdevice

On Tue, 11 Jun 2019, Gwendal Grignou wrote:

> With this patch, the cros_ec_ctl driver will register the legacy
> accelerometer driver (named cros_ec_accel_legacy) if it fails to
> register sensors through the usual path cros_ec_sensors_register().
> This legacy device is present on Chromebook devices with older EC
> firmware only supporting deprecated EC commands:
> - Glimmer based devices [Intel SOC using LPC transport]
> - Veyron minnie devices [ARM SOC using SPI transport]
> 
> Tested-by: Gwendal Grignou <gwendal@...omium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Signed-off-by: Gwendal Grignou <gwendal@...omium.org>
> ---
> Changes in v6:
> - Remove .id field in mfd_cell, PLATFORM_DEVID_AUTO is set to auto
>   assign ids.
> - Add support for ARM devices with older EC.
> 
> Changes in v5:
> - Remove unnecessary white lines.
> 
> Changes in v4:
> - [5/8] Nit: EC -> ECs (Lee Jones)
> - [5/8] Statically define cros_ec_accel_legacy_cells (Lee Jones)
> 
> Changes in v3:
> - [5/8] Add the Reviewed-by Andy Shevchenko.
> 
> Changes in v2:
> - [5/8] Add the Reviewed-by Gwendal.
> 
>  drivers/mfd/cros_ec_dev.c | 69 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 69 insertions(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog