linux-kernel - Re: PROBLEM: Marvell 88E8040 (sky2) fails after hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Jun 2019 12:08:52 -0500
From:   Octavio Alvarez <octallk1@...arezp.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Marc Zyngier <marc.zyngier@....com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Jiang Biao <jiang.biao2@....com.cn>,
        Yi Wang <wang.yi59@....com.cn>,
        Dou Liyang <douly.fnst@...fujitsu.com>,
        Nicolai Stange <nstange@...e.de>,
        Mirko Lindner <mlindner@...vell.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: PROBLEM: Marvell 88E8040 (sky2) fails after hibernation

On 6/23/19 7:54 AM, Thomas Gleixner wrote:
>>> I will keep trying 4.14, unless you say otherwise.
>>
>> It would be interesting though I don't expect too much data.
>>
>> So all of the above use PCI/MSI. That's at least a data point. I need to
>> stare into that driver again to figure out why this might make a
>> difference, but right now I'm lost.
> 
> One other data point you could provide please:
> 
>   Load the driver on Linus master with the following module parameter:
> 
>     disable_msi=1
> 
> That switches to INTx usage. Does the machine resume proper with that?

Hi, Thomas,

I did two tests:

If I boot with sky2.disable_msi=1 on the kernel cmdline then the problem 
goes away (when back from hibernation, the NIC works OK).

If I boot regularly (disable_msi not set) and then do modprobe -r sky2; 
modprobe sky2 disable_msi=1, the problem stays (when back from 
hibernation, the NIC does not work).

Tested on master (5.2-rc6).

Thanks,
Octavio.