linux-kernel - Re: PROBLEM: Marvell 88E8040 (sky2) fails after hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Jun 2019 03:48:45 +0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Octavio Alvarez <octallk1@...arezp.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Marc Zyngier <marc.zyngier@....com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Jiang Biao <jiang.biao2@....com.cn>,
        Yi Wang <wang.yi59@....com.cn>,
        Dou Liyang <douly.fnst@...fujitsu.com>,
        Nicolai Stange <nstange@...e.de>,
        Mirko Lindner <mlindner@...vell.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: PROBLEM: Marvell 88E8040 (sky2) fails after hibernation

On Tue, Jun 25, 2019 at 1:08 AM Octavio Alvarez <octallk1@...arezp.org> wrote:
>
> If I boot regularly (disable_msi not set) and then do modprobe -r sky2;
> modprobe sky2 disable_msi=1, the problem stays (when back from
> hibernation, the NIC does not work).

Side note: some distros end up unloading and reloading modules over suspend.

I wonder if perhaps your system does that, and then when it resumes it
has reloaded the sky2 driver, but without your manual "disable_msi=1"?

Because it sounds odd that it would work with the kernel command line
but not manually, and so I wonder if perhaps there's a hidden module
unload/load that causes that second case..

              Linus