linux-kernel - Re: PROBLEM: Marvell 88E8040 (sky2) fails after hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1906271632300.32342@nanos.tec.linutronix.de>
Date:   Thu, 27 Jun 2019 16:38:30 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Octavio Alvarez <octallk1@...arezp.org>
cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Marc Zyngier <marc.zyngier@....com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Jiang Biao <jiang.biao2@....com.cn>,
        Yi Wang <wang.yi59@....com.cn>,
        Dou Liyang <douly.fnst@...fujitsu.com>,
        Nicolai Stange <nstange@...e.de>,
        Mirko Lindner <mlindner@...vell.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: PROBLEM: Marvell 88E8040 (sky2) fails after hibernation

Octavio,

On Mon, 24 Jun 2019, Octavio Alvarez wrote:
> On 6/23/19 7:54 AM, Thomas Gleixner wrote:
> >   Load the driver on Linus master with the following module parameter:
> > 
> >     disable_msi=1
> > 
> > That switches to INTx usage. Does the machine resume proper with that?
> 
> I did two tests:
> 
> If I boot with sky2.disable_msi=1 on the kernel cmdline then the problem goes
> away (when back from hibernation, the NIC works OK).
> 
> If I boot regularly (disable_msi not set) and then do modprobe -r sky2;
> modprobe sky2 disable_msi=1, the problem stays (when back from hibernation,
> the NIC does not work).

Interesting. Did you verify that the driver still uses INTx after
hibernation in /proc/interrupts?

 cat /proc/interrupts | grep eth0

The 6st column should show IO-APIC for INTx. If it shows PCI-MSI then
something went wrong.

Also please check Linus suspicion about the module being reloaded after
hibernation through some distro magic.

Thanks,

	tglx