linux-kernel - Re: [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Jun 2019 08:56:43 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Chanwoo Choi <cw00.choi@...sung.com>
Cc:     cwchoi00@...il.com, Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Olof Johansson <olof@...om.net>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Simon Horman <horms+renesas@...ge.net.au>,
        Leonard Crestez <leonard.crestez@....com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Vasily Khoruzhick <anarsoul@...il.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers

On Mon, 24 Jun 2019 at 01:36, Chanwoo Choi <cw00.choi@...sung.com> wrote:
>
> On 19. 6. 24. 오전 4:16, Krzysztof Kozlowski wrote:
> > On Sun, 23 Jun 2019 at 06:31, Chanwoo Choi <cwchoi00@...il.com> wrote:
> >>
> >> Hi Krzysztof,
> >>
> >> 2019년 6월 23일 (일) 오전 4:20, Krzysztof Kozlowski <krzk@...nel.org>님이 작성:
> >>>
> >>> Enable support for Mali GPU with Panfrost and Lima drivers for:
> >>> 1. Samsung Exynos5433 and Exynos7 (having Mali T760),
> >>> 2. Allwiner A64 and H5 (Mali 400/450).
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> >>>
> >>> ---
> >>>
> >>> Changes since v1:
> >>> 1. Enable Lima driver
> >>> ---
> >>>  arch/arm64/configs/defconfig | 3 ++-
> >>>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> >>> index fbbc065415d4..3d31611368af 100644
> >>> --- a/arch/arm64/configs/defconfig
> >>> +++ b/arch/arm64/configs/defconfig
> >>> @@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=m
> >>>  CONFIG_DRM_HISI_KIRIN=m
> >>>  CONFIG_DRM_MESON=m
> >>>  CONFIG_DRM_PL111=m
> >>> +CONFIG_DRM_LIMA=m
> >>> +CONFIG_DRM_PANFROST=m
> >>>  CONFIG_FB=y
> >>>  CONFIG_FB_MODE_HELPERS=y
> >>>  CONFIG_BACKLIGHT_GENERIC=m
> >>> @@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
> >>>  CONFIG_ARCH_K3_AM6_SOC=y
> >>>  CONFIG_SOC_TI=y
> >>>  CONFIG_TI_SCI_PM_DOMAINS=y
> >>> -CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
> >>
> >> Exynos5433-tm2 board support the exynos-bus device which
> >> used the simple_ondmenad governor of devfreq.
> >> Why do you remove this configuration from the defconfig?
> >
> > It is selected by default by DRM_PANFROST. The difference is that
> > PANFROST selects it as module. The 'y' is chosen because of:
> >   SCSI_UFSHCD [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_DMA [=y]
>
> When I tried to find the history of CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND
> for defconfig, the following patch[1] added this configuration.
> [1] b972ff75f2938c39e2205c23ea0e531d36b27f86
> - "arm64: defconfig: Enable UFS on msm8996"
>
> I think that this patch will affect the opration of 'USF on msm8998'.

Hi Chanwoo,

Thanks for the feedback. Unfortunately I do not see how removing a
dependency will affect that SCSI_UFSHCD. The
DEVFREQ_GOV_SIMPLE_ONDEMAND is still built in, exactly the same as
before...

Best regards,
Krzysztof