lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Jun 2019 09:49:16 +0000 From: <Nicolas.Ferre@...rochip.com> To: <palmer@...ive.com>, <davem@...emloft.net> CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] net: macb: Kconfig: Rename Atmel to Cadence On 24/06/2019 at 08:16, Palmer Dabbelt wrote: > External E-Mail > > > When touching the Kconfig for this driver I noticed that both the > Kconfig help text and a comment referred to this being an Atmel driver. > As far as I know, this is a Cadence driver. The fix is just Indeed: was written and then maintained by Atmel (now Microchip) for years... So I would say that more than a "Cadence driver" it's a driver that applies to a Cadence peripheral. I won't hold the patch just for this as the patch makes perfect sense, but would love that it's been highlighted... > s/Atmel/Cadence/, but I did go and re-wrap the Kconfig help text as that > change caused it to go over 80 characters. > > Signed-off-by: Palmer Dabbelt <palmer@...ive.com> > --- > drivers/net/ethernet/cadence/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig > index 74ee2bfd2369..29b6132b418e 100644 > --- a/drivers/net/ethernet/cadence/Kconfig > +++ b/drivers/net/ethernet/cadence/Kconfig > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > # > -# Atmel device configuration > +# Cadence device configuration > # > > config NET_VENDOR_CADENCE > @@ -13,8 +13,8 @@ config NET_VENDOR_CADENCE > If unsure, say Y. > > Note that the answer to this question doesn't directly affect the > - kernel: saying N will just cause the configurator to skip all > - the remaining Atmel network card questions. If you say Y, you will be > + kernel: saying N will just cause the configurator to skip all the > + remaining Cadence network card questions. If you say Y, you will be > asked for your specific card in the following questions. > > if NET_VENDOR_CADENCE > -- Nicolas Ferre
Powered by blists - more mailing lists