linux-kernel - Re: [PATCH 2/2] net: macb: Kconfig: Rename Atmel to Cadence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-87f5f418-acd4-4a29-b82e-6dc574a4828a@palmer-si-x1e>
Date:   Mon, 24 Jun 2019 02:57:22 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...ive.com>
To:     Nicolas.Ferre@...rochip.com
CC:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject:     Re: [PATCH 2/2] net: macb: Kconfig: Rename Atmel to Cadence

On Mon, 24 Jun 2019 02:49:16 PDT (-0700), Nicolas.Ferre@...rochip.com wrote:
> On 24/06/2019 at 08:16, Palmer Dabbelt wrote:
>> External E-Mail
>> 
>> 
>> When touching the Kconfig for this driver I noticed that both the
>> Kconfig help text and a comment referred to this being an Atmel driver.
>> As far as I know, this is a Cadence driver.  The fix is just
> 
> Indeed: was written and then maintained by Atmel (now Microchip) for 
> years... So I would say that more than a "Cadence driver" it's a driver 
> that applies to a Cadence peripheral.
> 
> I won't hold the patch just for this as the patch makes perfect sense, 
> but would love that it's been highlighted...

OK, I don't mind changing it.  Does this look OK?  I have to submit a v2 anyway
for the first patch.

Author: Palmer Dabbelt <palmer@...ive.com>
Date:   Sun Jun 23 23:04:14 2019 -0700

    net: macb: Kconfig: Rename Atmel to Cadence

    The help text makes it look like NET_VENDOR_CADENCE enables support for
    Atmel devices, when in reality it's a driver written by Atmel that
    supports Cadence devices.  This may confuse users that have this device
    on a non-Atmel SoC.

    The fix is just s/Atmel/Cadence/, but I did go and re-wrap the Kconfig
    help text as that change caused it to go over 80 characters.

    Signed-off-by: Palmer Dabbelt <palmer@...ive.com>

diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
index 74ee2bfd2369..29b6132b418e 100644
--- a/drivers/net/ethernet/cadence/Kconfig
+++ b/drivers/net/ethernet/cadence/Kconfig
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 #
-# Atmel device configuration
+# Cadence device configuration
 #

 config NET_VENDOR_CADENCE
@@ -13,8 +13,8 @@ config NET_VENDOR_CADENCE
          If unsure, say Y.

          Note that the answer to this question doesn't directly affect the
-         kernel: saying N will just cause the configurator to skip all
-         the remaining Atmel network card questions. If you say Y, you will be
+         kernel: saying N will just cause the configurator to skip all the
+         remaining Cadence network card questions. If you say Y, you will be
          asked for your specific card in the following questions.

 if NET_VENDOR_CADENCE

> 
>> s/Atmel/Cadence/, but I did go and re-wrap the Kconfig help text as that
>> change caused it to go over 80 characters.
>> 
>> Signed-off-by: Palmer Dabbelt <palmer@...ive.com>
>> ---
>>   drivers/net/ethernet/cadence/Kconfig | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
>> index 74ee2bfd2369..29b6132b418e 100644
>> --- a/drivers/net/ethernet/cadence/Kconfig
>> +++ b/drivers/net/ethernet/cadence/Kconfig
>> @@ -1,6 +1,6 @@
>>   # SPDX-License-Identifier: GPL-2.0-only
>>   #
>> -# Atmel device configuration
>> +# Cadence device configuration
>>   #
>>   
>>   config NET_VENDOR_CADENCE
>> @@ -13,8 +13,8 @@ config NET_VENDOR_CADENCE
>>   	  If unsure, say Y.
>>   
>>   	  Note that the answer to this question doesn't directly affect the
>> -	  kernel: saying N will just cause the configurator to skip all
>> -	  the remaining Atmel network card questions. If you say Y, you will be
>> +	  kernel: saying N will just cause the configurator to skip all the
>> +	  remaining Cadence network card questions. If you say Y, you will be
>>   	  asked for your specific card in the following questions.
>>   
>>   if NET_VENDOR_CADENCE
>> 
> 
> 
> -- 
> Nicolas Ferre