linux-kernel - Re: [PATCH] bluetooth: Cleanup formatting and coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Jun 2019 14:56:33 -0700
From:   Joe Perches <joe@...ches.com>
To:     Fabian Schindlatz <fabian.schindlatz@....de>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Thomas Röthenbacher 
        <thomas.roethenbacher@....de>, linux-kernel@...cs.fau.de
Subject: Re: [PATCH] bluetooth: Cleanup formatting and coding style

On Sun, 2019-06-23 at 23:15 +0200, Fabian Schindlatz wrote:
> Fix some warnings and one error reported by checkpatch.pl:
[]
> diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
[]
> @@ -351,7 +356,8 @@ static int ll_enqueue(struct hci_uart *hu, struct sk_buff *skb)
>  		skb_queue_tail(&ll->tx_wait_q, skb);
>  		break;
>  	default:
> -		BT_ERR("illegal hcill state: %ld (losing packet)", ll->hcill_state);
> +		BT_ERR("illegal hcill state: %ld (losing packet)",

trivia:

Might use invalid instead of illegal as no crime was committed.