linux-kernel - Re: [tip:locking/core] locking/lockdep: Move mark_lock() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190625121624.nypo3qmbtfpl5f4r@willie-the-truck>
Date:   Tue, 25 Jun 2019 13:16:25 +0100
From:   Will Deacon <will@...nel.org>
To:     will.deacon@....com, tglx@...utronix.de, frederic@...nel.org,
        mingo@...nel.org, longman@...hat.com, bvanassche@....org,
        paulmck@...ux.vnet.ibm.com, peterz@...radead.org,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, duyuyang@...il.com, torvalds@...ux-foundation.org,
        hpa@...or.com
Subject: Re: [tip:locking/core] locking/lockdep: Move mark_lock() inside
 CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING

On Tue, Jun 25, 2019 at 01:46:07AM -0700, tip-bot for Arnd Bergmann wrote:
> Commit-ID:  886532aee3cd42d95196601ed16d7c3d4679e9e5
> Gitweb:     https://git.kernel.org/tip/886532aee3cd42d95196601ed16d7c3d4679e9e5
> Author:     Arnd Bergmann <arnd@...db.de>
> AuthorDate: Mon, 17 Jun 2019 14:47:05 +0200
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Tue, 25 Jun 2019 10:17:07 +0200
> 
> locking/lockdep: Move mark_lock() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING
> 
> The last cleanup patch triggered another issue, as now another function
> should be moved into the same section:
> 
>  kernel/locking/lockdep.c:3580:12: error: 'mark_lock' defined but not used [-Werror=unused-function]
>   static int mark_lock(struct task_struct *curr, struct held_lock *this,
> 
> Move mark_lock() into the same #ifdef section as its only caller, and
> remove the now-unused mark_lock_irq() stub helper.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Bart Van Assche <bvanassche@....org>
> Cc: Frederic Weisbecker <frederic@...nel.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Waiman Long <longman@...hat.com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: Yuyang Du <duyuyang@...il.com>
> Fixes: 0d2cc3b34532 ("locking/lockdep: Move valid_state() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING")
> Link: https://lkml.kernel.org/r/20190617124718.1232976-1-arnd@arndb.de
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> ---
>  kernel/locking/lockdep.c | 73 ++++++++++++++++++++++--------------------------
>  1 file changed, 34 insertions(+), 39 deletions(-)

Hmm, I was hoping we could fold in the simplification that Arnd came up with
yesterday:

https://lkml.kernel.org/r/CAK8P3a2X_5p9QOKG-jcozR4P8iPNJAY2ObXgfqt=bBD+hZdnSg@mail.gmail.com

Will