linux-kernel - Re: [PATCH 2/2] ASoC: soc-core: support dai_link with platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   27 Jun 2019 08:44:08 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Jerome Brunet <jbrunet@...libre.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Kevin Hilman <khilman@...libre.com>,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH 2/2] ASoC: soc-core: support dai_link with platforms_num != 1


Hi Jerome

Thank you for your patch.
This is nice !

> Add support platforms_num != 1 in dai_link. Initially, the main purpose of
> this change was to make the platform optional in the dai_link, instead of
> inserting the dummy platform driver.
> 
> This particular case had just been solved by Kuninori Morimoto with
> commit 1d7689892878 ("ASoC: soc-core: allow no Platform on dai_link").
> 
> However, this change may still be useful for those who need multiple
> platform components on a single dai_link (it solves one of the FIXME
> note in soc-core)
> 
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> ---
(snip)
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 002ddbf4e5a3..3053a4a461b3 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -887,7 +887,7 @@ static int soc_bind_dai_link(struct snd_soc_card *card,
>  	struct snd_soc_dai_link *dai_link)
>  {
>  	struct snd_soc_pcm_runtime *rtd;
> -	struct snd_soc_dai_link_component *codecs;
> +	struct snd_soc_dai_link_component *dlc;
>  	struct snd_soc_component *component;
>  	int i;

This is nitpick, but having both "codecs" and "platforms" is
easy to read / understand code.

> @@ -1051,22 +1053,22 @@ static int soc_init_dai_link(struct snd_soc_card *card,
>  			     struct snd_soc_dai_link *link)
>  {
>  	int i;
> -	struct snd_soc_dai_link_component *codec;
> +	struct snd_soc_dai_link_component *dlc;

Same here.

For other parts

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

Thank you for your help !!
Best regards
---
Kuninori Morimoto