[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190626234333.GA20313@tower.DHCP.thefacebook.com>
Date: Wed, 26 Jun 2019 23:43:38 +0000
From: Roman Gushchin <guro@...com>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
CC: Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Stephen Rothwell <sfr@...b.auug.org.au>,
Networking <netdev@...r.kernel.org>,
Linux Next Mailing List <linux-next@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the bpf tree
On Wed, Jun 26, 2019 at 04:36:50PM -0700, Alexei Starovoitov wrote:
> On Wed, Jun 26, 2019 at 3:14 PM Roman Gushchin <guro@...com> wrote:
> >
> > On Thu, Jun 27, 2019 at 08:05:21AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > In commit
> > >
> > > 12771345a467 ("bpf: fix cgroup bpf release synchronization")
> > >
> > > Fixes tag
> > >
> > > Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from
> > >
> > > has these problem(s):
> > >
> > > - Subject has leading but no trailing parentheses
> > > - Subject has leading but no trailing quotes
> > >
> > > Please don't split Fixes tags across more than one line.
> >
> > Oops, sorry.
> >
> > Alexei, can you fix this in place?
> > Or should I send an updated version?
>
> I cannot easily do it since -p and --signoff are incompatible flags.
> I need to use -p to preserve merge commits,
> but I also need to use --signoff to add my sob to all
> other commits that were committed by Daniel
> after your commit.
I see... Sorry for the hassle!
>
> Daniel, can you fix Roman's patch instead?
> you can do:
> git rebase -i -p 12771345a467^
> fix Roman's, add you sob only to that one
> and re-push the whole thing.
Thanks!
Powered by blists - more mailing lists