[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190626033038.9456-1-zbestahu@gmail.com>
Date: Wed, 26 Jun 2019 11:30:38 +0800
From: Yue Hu <zbestahu@...il.com>
To: gaoxiang25@...wei.com, yuchao0@...wei.com,
gregkh@...uxfoundation.org
Cc: linux-erofs@...ts.ozlabs.org, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org, huyue2@...ong.com
Subject: [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails
From: Yue Hu <huyue2@...ong.com>
We should consider the error returned by fill_inline_data() when filling
last page in fill_inode(). If not getting inode will be successful even
though last page is bad. That is illogical. Also change -EAGAIN to 0 in
fill_inline_data() to stand for successful filling.
Signed-off-by: Yue Hu <huyue2@...ong.com>
---
drivers/staging/erofs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index d6e1e16..1433f25 100644
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -156,7 +156,7 @@ static int fill_inline_data(struct inode *inode, void *data,
inode->i_link = lnk;
set_inode_fast_symlink(inode);
}
- return -EAGAIN;
+ return 0;
}
static int fill_inode(struct inode *inode, int isdir)
@@ -223,7 +223,7 @@ static int fill_inode(struct inode *inode, int isdir)
inode->i_mapping->a_ops = &erofs_raw_access_aops;
/* fill last page if inline data is available */
- fill_inline_data(inode, data, ofs);
+ err = fill_inline_data(inode, data, ofs);
}
out_unlock:
--
1.9.1
Powered by blists - more mailing lists