linux-kernel - Re: [PATCH RESEND] staging: erofs: return the error value if fill_inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96f12ad4-e9dc-a688-2c26-2dd285b7b795@huawei.com>
Date:   Wed, 26 Jun 2019 15:13:52 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Yue Hu <zbestahu@...il.com>, <gaoxiang25@...wei.com>,
        <gregkh@...uxfoundation.org>
CC:     <linux-erofs@...ts.ozlabs.org>, <devel@...verdev.osuosl.org>,
        <linux-kernel@...r.kernel.org>, <huyue2@...ong.com>
Subject: Re: [PATCH RESEND] staging: erofs: return the error value if
 fill_inline_data() fails

On 2019/6/26 11:30, Yue Hu wrote:
> From: Yue Hu <huyue2@...ong.com>
> 
> We should consider the error returned by fill_inline_data() when filling
> last page in fill_inode(). If not getting inode will be successful even
> though last page is bad. That is illogical. Also change -EAGAIN to 0 in
> fill_inline_data() to stand for successful filling.
> 
> Signed-off-by: Yue Hu <huyue2@...ong.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,