linux-kernel - Re: [Cluster-devel] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Jun 2019 08:20:42 -0400 (EDT)
From:   Bob Peterson <rpeterso@...hat.com>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     matthew garrett <matthew.garrett@...ula.com>, yuchao0@...wei.com,
        tytso@....edu, shaggy@...nel.org,
        ard biesheuvel <ard.biesheuvel@...aro.org>,
        josef@...icpanda.com, hch@...radead.org, clm@...com,
        adilger kernel <adilger.kernel@...ger.ca>, jk@...abs.org,
        jack@...e.com, dsterba@...e.com, jaegeuk@...nel.org,
        viro@...iv.linux.org.uk, linux-xfs@...r.kernel.org,
        jfs-discussion@...ts.sourceforge.net, linux-efi@...r.kernel.org,
        Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
        reiserfs-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        cluster-devel@...hat.com, linux-nilfs@...r.kernel.org,
        linux-mtd@...ts.infradead.org, linux-btrfs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        Christoph Hellwig <hch@....de>, ocfs2-devel@....oracle.com
Subject: Re: [Cluster-devel] [PATCH 1/5] vfs: create a generic checking and
 prep function for FS_IOC_SETFLAGS

----- Original Message -----
> From: Darrick J. Wong <darrick.wong@...cle.com>
> 
> Create a generic function to check incoming FS_IOC_SETFLAGS flag values
> and later prepare the inode for updates so that we can standardize the
> implementations that follow ext4's flag values.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> Reviewed-by: Jan Kara <jack@...e.cz>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Acked-by: David Sterba <dsterba@...e.com>
> ---
>  fs/btrfs/ioctl.c    |   13 +++++--------
>  fs/efivarfs/file.c  |   26 +++++++++++++++++---------
>  fs/ext2/ioctl.c     |   16 ++++------------
>  fs/ext4/ioctl.c     |   13 +++----------
>  fs/f2fs/file.c      |    7 ++++---
>  fs/gfs2/file.c      |   42 +++++++++++++++++++++++++++++-------------
>  fs/hfsplus/ioctl.c  |   21 ++++++++++++---------
>  fs/inode.c          |   24 ++++++++++++++++++++++++
>  fs/jfs/ioctl.c      |   22 +++++++---------------
>  fs/nilfs2/ioctl.c   |    9 ++-------
>  fs/ocfs2/ioctl.c    |   13 +++----------
>  fs/orangefs/file.c  |   35 ++++++++++++++++++++++++++---------
>  fs/reiserfs/ioctl.c |   10 ++++------
>  fs/ubifs/ioctl.c    |   13 +++----------
>  include/linux/fs.h  |    3 +++
>  15 files changed, 146 insertions(+), 121 deletions(-)

The gfs2 portion looks correct.

Reviewed-by: Bob Peterson <rpeterso@...hat.com>

Regards,

Bob Peterson