linux-kernel - Re: [PATCH v3] arm64: rename dump_instr as dump_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190626122134.fg7s6di5o3d3gim4@willie-the-truck>
Date:   Wed, 26 Jun 2019 13:21:35 +0100
From:   Will Deacon <will@...nel.org>
To:     jinho lim <jordan.lim@...sung.com>, catalin.marinas@....com
Cc:     will.deacon@....com, mark.rutland@....com,
        anshuman.khandual@....com, marc.zyngier@....com,
        andreyknvl@...gle.com, linux-kernel@...r.kernel.org,
        seroto7@...il.com, ebiederm@...ssion.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3] arm64: rename dump_instr as dump_kernel_instr

On Wed, Jun 26, 2019 at 08:50:13PM +0900, jinho lim wrote:
> In traps.c, only __die calls dump_instr.
> However, this function has sub-function as __dump_instr.
> 
> dump_kernel_instr can replace those functions.
> By using aarch64_insn_read, it does not have to change fs to KERNEL_DS.
> 
> Signed-off-by: jinho lim <jordan.lim@...sung.com>
> ---
>  arch/arm64/kernel/traps.c | 23 +++++++----------------
>  1 file changed, 7 insertions(+), 16 deletions(-)

Thanks, this looks good to me now:

Acked-by: Will Deacon <will.deacon@....com>

Catalin can pick this up for 5.3.

Will