[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8be81390-a627-6bc9-1218-4d62f41eaeff@linaro.org>
Date: Thu, 27 Jun 2019 15:31:32 +0200
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Zhang Rui <rui.zhang@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
amit.kucheria@...aro.org
Subject: Re: [PATCH 1/2] thermal/drivers/core: Add init section table for
self-encapsulation
On 27/06/2019 15:21, Zhang Rui wrote:
> On 一, 2019-06-24 at 09:32 +0200, Daniel Lezcano wrote:
>> Any chance this patch gets merged for v5.4?
>>
>> Thanks
>> -- Daniel
>>
>
> have you run compile test for the patch?
> I got the following errors when compiling.
Yes I did and also booted, changed the governor at runtime, etc ... I
already got this error and fixed it. I probably forgot to fold or commit
the fix ... :/
> In file included from drivers/thermal/fair_share.c:16:0:
> drivers/thermal/thermal_core.h:23:3: error: expected identifier or ‘(’
> before ‘static’
> (static typeof(name) *__thermal_table_entry_##name \
> ^
> drivers/thermal/thermal_core.h:26:40: note: in expansion of macro
> ‘THERMAL_TABLE_ENTRY’
> #define THERMAL_GOVERNOR_DECLARE(name) THERMAL_TABLE_ENTRY(governor,
> name)
> ^
[ ... ]
> ^
> make[2]: *** [drivers/thermal/gov_bang_bang.o] Error 1
> make[1]: *** [drivers/thermal] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [drivers] Error 2
>
> Fix the problem by removing the round brackets
> of THERMAL_TABLE_ENTRY(), and applied.
Ok, thanks for fixing it!
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists