linux-kernel - Re: [PATCH v3] mtd: spinand: read return badly if the last page has bitflips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190628183656.18875-1-miquel.raynal@bootlin.com>
Date:   Fri, 28 Jun 2019 20:36:56 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     liaoweixiong <liaoweixiong@...winnertech.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Frieder Schrempf <frieder.schrempf@...eet.de>,
        Peter Pan <peterpandong@...ron.com>,
        Jeff Kletsky <git-commits@...ycomm.com>,
        Schrempf Frieder <frieder.schrempf@...tron.De>
Cc:     linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH v3] mtd: spinand: read return badly if the last page has bitflips

On Fri, 2019-06-28 at 04:14:46 UTC, liaoweixiong wrote:
> In case of the last page containing bitflips (ret > 0),
> spinand_mtd_read() will return that number of bitflips for the last
> page. But to me it looks like it should instead return max_bitflips like
> it does when the last page read returns with 0.
> 
> Signed-off-by: Weixiong Liao <liaoweixiong@...winnertech.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com>
> Reviewed-by: Frieder Schrempf <frieder.schrempf@...tron.de>
> Cc: stable@...r.kernel.org
> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel