[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1561695286-19265-1-git-send-email-liaoweixiong@allwinnertech.com>
Date: Fri, 28 Jun 2019 12:14:46 +0800
From: liaoweixiong <liaoweixiong@...winnertech.com>
To: Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>,
David Woodhouse <dwmw2@...radead.org>,
Brian Norris <computersforpeace@...il.com>,
Marek Vasut <marek.vasut@...il.com>,
Vignesh Raghavendra <vigneshr@...com>,
Boris Brezillon <bbrezillon@...nel.org>,
Frieder Schrempf <frieder.schrempf@...eet.de>,
Peter Pan <peterpandong@...ron.com>,
Jeff Kletsky <git-commits@...ycomm.com>,
Schrempf Frieder <frieder.schrempf@...tron.De>
Cc: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
liaoweixiong <liaoweixiong@...winnertech.com>,
stable@...r.kernel.org
Subject: [PATCH v3] mtd: spinand: read return badly if the last page has bitflips
In case of the last page containing bitflips (ret > 0),
spinand_mtd_read() will return that number of bitflips for the last
page. But to me it looks like it should instead return max_bitflips like
it does when the last page read returns with 0.
Signed-off-by: Weixiong Liao <liaoweixiong@...winnertech.com>
Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com>
Reviewed-by: Frieder Schrempf <frieder.schrempf@...tron.de>
Cc: stable@...r.kernel.org
Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
---
Changes since v2:
- Resend this patch with Cc and Fixes tags.
Changes since v1:
- More accurate description for this patch
---
drivers/mtd/nand/spi/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
index 556bfdb..6b9388d 100644
--- a/drivers/mtd/nand/spi/core.c
+++ b/drivers/mtd/nand/spi/core.c
@@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from,
if (ret == -EBADMSG) {
ecc_failed = true;
mtd->ecc_stats.failed++;
- ret = 0;
} else {
mtd->ecc_stats.corrected += ret;
max_bitflips = max_t(unsigned int, max_bitflips, ret);
}
+ ret = 0;
ops->retlen += iter.req.datalen;
ops->oobretlen += iter.req.ooblen;
}
--
1.9.1
Powered by blists - more mailing lists