linux-kernel - Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jun 2019 08:58:41 +0530
From:   Keerthy <j-keerthy@...com>
To:     Colin King <colin.king@...onical.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Lee Jones <lee.jones@...aro.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] regulator: lp87565: fix missing break in switch
 statement



On 27/06/19 6:46 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a
> break statement, causing it to fall through to a dev_err message.
> Fix this by adding in the missing break statement.
> 
> Addresses-Coverity: ("Missing break in switch")
> Fixes: 7ee63bd74750 ("regulator: lp87565: Add 4-phase lp87561 regulator support")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/regulator/lp87565-regulator.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565-regulator.c
> index 993c11702083..5d067f7c2116 100644
> --- a/drivers/regulator/lp87565-regulator.c
> +++ b/drivers/regulator/lp87565-regulator.c
> @@ -180,6 +180,7 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
>   	case LP87565_DEVICE_TYPE_LP87561_Q1:
>   		min_idx = LP87565_BUCK_3210;
>   		max_idx = LP87565_BUCK_3210;
> +		break;

Thanks Colin.

Reviewed-by: Keerthy <j-keerthy@...com>

>   	default:
>   		dev_err(lp87565->dev, "Invalid lp config %d\n",
>   			lp87565->dev_type);
>