[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8b8c44c3ecb8626d9bb5a8f786b1d2b7488df86b.camel@sipsolutions.net>
Date: Fri, 28 Jun 2019 15:57:05 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Shuah Khan <skhan@...uxfoundation.org>,
Jiunn Chang <c0d1n61at3@...il.com>
Cc: linux-kernel-mentees@...ts.linuxfoundation.org,
linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Linux-kernel-mentees][PATCH v2] nl80211: Fix undefined
behavior in bit shift
On Wed, 2019-06-26 at 21:34 -0600, Shuah Khan wrote:
> On 6/26/19 9:25 PM, Jiunn Chang wrote:
> > Shifting signed 32-bit value by 31 bits is undefined. Changing most
> > significant bit to unsigned.
> >
> > Changes included in v2:
> > - use subsystem specific subject lines
> > - CC required mailing lists
> >
> > Signed-off-by: Jiunn Chang <c0d1n61at3@...il.com>
> > ---
>
> Move version change lines here. They don't belong in the commit log.
FWIW, in many cases people (maintainers) now *do* want them in the
commit log. Here, they're just editorial, so agree, but if real
technical changes were made due to reviews, they can indeed be useful.
johannes
Powered by blists - more mailing lists