linux-kernel - Re: [PATCH v2 0/3] block: sed-opal: add support for shadow MBR done flag and write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 Jun 2019 12:19:55 -0400
From:   Scott Bauer <sbauer@...donthack.me>
To:     axboe@...nel.dk
Cc:     jonathan.derrick@...el.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "zub@...ux.fjfi.cvut.cz" <zub@...ux.fjfi.cvut.cz>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "jonas.rabenstein@...dium.uni-erlangen.de" 
        <jonas.rabenstein@...dium.uni-erlangen.de>
Subject: Re: [PATCH v2 0/3] block: sed-opal: add support for shadow MBR done
 flag and write


Hey Jens,

Can you please stage these for 5.3 aswell?


On Tue, Jun 25, 2019 at 08:47:26PM +0000, Derrick, Jonathan wrote:
> These are still good with me and we'll likely have a similar future use
> for passing data through the ioctl.
> 
> Could we get this staged for 5.3?
> 
> On Tue, 2019-05-21 at 22:46 +0200, David Kozub wrote:
> > This patch series extends SED Opal support: it adds IOCTL for setting the shadow
> > MBR done flag which can be useful for unlocking an Opal disk on boot and it adds
> > IOCTL for writing to the shadow MBR.
> > 
> > This applies on current master.
> > 
> > I successfully tested toggling the MBR done flag and writing the shadow MBR
> > using some tools I hacked together[1] with a Samsung SSD 850 EVO drive.
> > 
> > Changes from v1:
> > * PATCH 2/3: remove check with access_ok, just rely on copy_from_user as
> > suggested in [2] (I tested passing data == 0 and I got the expected EFAULT)
> > 
> > [1] https://gitlab.com/zub2/opalctl
> > [2] https://lore.kernel.org/lkml/20190501134833.GB24132@infradead.org/
> > 
> > Jonas Rabenstein (3):
> >   block: sed-opal: add ioctl for done-mark of shadow mbr
> >   block: sed-opal: ioctl for writing to shadow mbr
> >   block: sed-opal: check size of shadow mbr
> > 
> >  block/opal_proto.h            |  16 ++++
> >  block/sed-opal.c              | 157 +++++++++++++++++++++++++++++++++-
> >  include/linux/sed-opal.h      |   2 +
> >  include/uapi/linux/sed-opal.h |  20 +++++
> >  4 files changed, 193 insertions(+), 2 deletions(-)
> >