linux-kernel - Re: [linux-kernel-mentees] [PATCH v1] Doc : fs : convert xfs.txt to ReST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 Jul 2019 09:54:23 -0500
From:   Eric Sandeen <sandeen@...deen.net>
To:     Jonathan Corbet <corbet@....net>,
        Sheriff Esseson <sheriffesseson@...il.com>
Cc:     skhan@...uxfoundation.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        darrick.wong@...cle.com, linux-xfs@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [linux-kernel-mentees] [PATCH v1] Doc : fs : convert xfs.txt to
 ReST



On 6/30/19 12:32 PM, Jonathan Corbet wrote:
> On Sun, 30 Jun 2019 17:50:46 +0100
> Sheriff Esseson <sheriffesseson@...il.com> wrote:
> 
>> On Sat, Jun 29, 2019 at 09:57:59PM +0100, Sheriff Esseson wrote:
>>> Signed-off-by: Sheriff Esseson <sheriffesseson@...il.com>
>>> ---
>>>
>>> In v3:
>>> Update MAINTAINERS. Fix Indentation/long line issues. Insert Sphinx tag.
>>>
>>> -- 
>>> 2.22.0
>>>   
>>
>> Signed-off-by: Sheriff Esseson <sheriffesseson@...il.com>
>> ---
>>
>> In v4:
>> dax.txt : 
>> 	fix broken reference to xfs.rst
> 
> I will now repeat what I said yesterday:
> 
>> Please do us a favor?  
>>
>> 1) Post each patch standalone, without quoted text, ready to be applied.

To be maybe more explicit,

While we appreciate the eagerness here I'd like to reiterate that the
followup V2, V3, ... patches should each be a standalone, self-contained
email, without any quoted text and with updated subject lines, i.e.

Subject: [PATCH] Doc : fs : convert xfs.txt to ReST

followed by:

Subject: [PATCH V2] Doc : fs : convert xfs.txt to ReST

followed by:

Subject: [PATCH V3] Doc : fs : convert xfs.txt to ReST

so it's trivial to see from subject lines when a new version has been
sent.

Also, what Jonathan said about time between iterations.  ;)

Thanks,
-Eric


>> 2) Wait a little while between postings so that you can address more than
>> one comment at a time.
>>
>> OK, two favors - off-by-one errors are my specialty...:)
> 
> I did actually mean that.  For "a little while" I meant "a few days or
> so".  Please slow down a little.  In any case, we're getting closer to the
> merge window, so this patch won't be applied for a while regardless.
> 
> Thanks,
> 
> jon
>