linux-kernel - Re: [PATCH] blk-mq: Use seq_puts() in __blk_mq_debugfs_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2a06dfd-4a03-2f56-59e6-abce261653d6@acm.org>
Date:   Mon, 1 Jul 2019 12:47:56 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Markus Elfring <Markus.Elfring@....de>,
        linux-block@...r.kernel.org, Jens Axboe <axboe@...nel.dk>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] blk-mq: Use seq_puts() in __blk_mq_debugfs_rq_show()

On 7/1/19 12:27 PM, Markus Elfring wrote:
> A string which did not contain a data format specification should be put
> into a sequence. Thus use the corresponding function “seq_puts”.

"should"? Why should this be done? Or in other words, what is wrong with 
the current code other than that it is slightly verbose and slightly 
slower than seq_puts()? Do you think this matters for debugfs code?

Thanks,

Bart.