linux-kernel - Re: blk-mq: Use seq_puts() in __blk_mq_debugfs_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a8b6e93-72fb-1900-3338-662db7b8975d@web.de>
Date:   Mon, 1 Jul 2019 22:00:21 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Bart Van Assche <bvanassche@....org>, Jens Axboe <axboe@...nel.dk>,
        linux-block@...r.kernel.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: blk-mq: Use seq_puts() in __blk_mq_debugfs_rq_show()

>> A string which did not contain a data format specification should be put
>> into a sequence. Thus use the corresponding function “seq_puts”.
>
> Why should this be done?

Do you prefer an other wording for the desired data output?


> Or in other words, what is wrong with the current code
> other than that it is slightly verbose and slightly slower than seq_puts()?

I suggest to improve such implementation details also at this place.

Regards,
Markus