linux-kernel - RE: [PATCH v2 09/11] firmware: xilinx: Add SDIO Tap Delay APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <MN2PR02MB6029CA4163882081D7B8C255C1F80@MN2PR02MB6029.namprd02.prod.outlook.com>
Date:   Tue, 2 Jul 2019 05:03:35 +0000
From:   Manish Narani <MNARANI@...inx.com>
To:     Jolly Shah <JOLLYS@...inx.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "heiko@...ech.de" <heiko@...ech.de>,
        Michal Simek <michals@...inx.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "christoph.muellner@...obroma-systems.com" 
        <christoph.muellner@...obroma-systems.com>,
        "philipp.tomsich@...obroma-systems.com" 
        <philipp.tomsich@...obroma-systems.com>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "scott.branden@...adcom.com" <scott.branden@...adcom.com>,
        "ayaka@...lik.info" <ayaka@...lik.info>,
        "kernel@...il.dk" <kernel@...il.dk>,
        "tony.xie@...k-chips.com" <tony.xie@...k-chips.com>,
        Rajan Vaja <RAJANV@...inx.com>,
        Nava kishore Manne <navam@...inx.com>,
        "mdf@...nel.org" <mdf@...nel.org>,
        "olof@...om.net" <olof@...om.net>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-rockchip@...ts.infradead.org" 
        <linux-rockchip@...ts.infradead.org>
Subject: RE: [PATCH v2 09/11] firmware: xilinx: Add SDIO Tap Delay APIs

Hi Jolly,


> -----Original Message-----
> From: Jolly Shah
> Sent: Monday, July 1, 2019 11:36 PM
> To: Manish Narani <MNARANI@...inx.com>; ulf.hansson@...aro.org;
> robh+dt@...nel.org; mark.rutland@....com; heiko@...ech.de; Michal Simek
> <michals@...inx.com>; adrian.hunter@...el.com;
> christoph.muellner@...obroma-systems.com; philipp.tomsich@...obroma-
> systems.com; viresh.kumar@...aro.org; scott.branden@...adcom.com;
> ayaka@...lik.info; kernel@...il.dk; tony.xie@...k-chips.com; Rajan Vaja
> <RAJANV@...inx.com>; Nava kishore Manne <navam@...inx.com>;
> mdf@...nel.org; Manish Narani <MNARANI@...inx.com>; olof@...om.net
> Cc: linux-mmc@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> rockchip@...ts.infradead.org
> Subject: RE: [PATCH v2 09/11] firmware: xilinx: Add SDIO Tap Delay APIs
> 
> Hi Manish,
> 
> > -----Original Message-----
> > From: Manish Narani <manish.narani@...inx.com>
> > Sent: Sunday, June 30, 2019 10:30 PM
> > To: ulf.hansson@...aro.org; robh+dt@...nel.org; mark.rutland@....com;
> > heiko@...ech.de; Michal Simek <michals@...inx.com>;
> > adrian.hunter@...el.com; christoph.muellner@...obroma-systems.com;
> > philipp.tomsich@...obroma-systems.com; viresh.kumar@...aro.org;
> > scott.branden@...adcom.com; ayaka@...lik.info; kernel@...il.dk;
> > tony.xie@...k-chips.com; Rajan Vaja <RAJANV@...inx.com>; Jolly Shah
> > <JOLLYS@...inx.com>; Nava kishore Manne <navam@...inx.com>;
> > mdf@...nel.org; Manish Narani <MNARANI@...inx.com>; olof@...om.net
> > Cc: linux-mmc@...r.kernel.org; devicetree@...r.kernel.org; linux-
> > kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> > rockchip@...ts.infradead.org
> > Subject: [PATCH v2 09/11] firmware: xilinx: Add SDIO Tap Delay APIs
> >
> > Add APIs for setting SDIO Tap Delays on ZynqMP platform.
> >
> > Signed-off-by: Manish Narani <manish.narani@...inx.com>
> > ---
> >  drivers/firmware/xilinx/zynqmp.c     | 48
> > ++++++++++++++++++++++++++++++++++++
> >  include/linux/firmware/xlnx-zynqmp.h | 15 ++++++++++-
> >  2 files changed, 62 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/xilinx/zynqmp.c
> b/drivers/firmware/xilinx/zynqmp.c
> > index fd3d837..b81f1be 100644
> > --- a/drivers/firmware/xilinx/zynqmp.c
> > +++ b/drivers/firmware/xilinx/zynqmp.c
> > @@ -664,6 +664,52 @@ static int zynqmp_pm_set_requirement(const u32
> > node, const u32 capabilities,
> >  				   qos, ack, NULL);
> >  }
> >
> > +/**
> > + * zynqmp_pm_sdio_out_setphase() - PM call to set clock output delays for
> SD
> > + * @device_id:		Device ID of the SD controller
> > + * @tap_delay:		Tap Delay value for output clock
> > + *
> > + * This API function is to be used for setting the clock output delays for SD
> > + * clock.
> > + *
> > + * Return: Returns status, either success or error+reason
> > + */
> > +static int zynqmp_pm_sdio_out_setphase(u32 device_id, u8 tap_delay)
> > +{
> > +	u32 node_id = (!device_id) ? NODE_SD_0 : NODE_SD_1;
> > +	int ret;
> > +
> > +	ret = zynqmp_pm_ioctl(node_id, IOCTL_SET_SD_TAPDELAY,
> > +			      PM_TAPDELAY_OUTPUT, tap_delay, NULL);
> > +	if (ret)
> > +		pr_err("Error setting Output Tap Delay\n");
> > +
> > +	return ret;
> > +}
> > +
> > +/**
> > + * zynqmp_pm_sdio_in_setphase() - PM call to set clock input delays for SD
> > + * @device_id:		Device ID of the SD controller
> > + * @tap_delay:		Tap Delay value for input clock
> > + *
> > + * This API function is to be used for setting the clock input delays for SD
> > + * clock.
> > + *
> > + * Return: Returns status, either success or error+reason
> > + */
> > +static int zynqmp_pm_sdio_in_setphase(u32 device_id, u8 tap_delay)
> > +{
> > +	u32 node_id = (!device_id) ? NODE_SD_0 : NODE_SD_1;
> > +	int ret;
> > +
> > +	ret = zynqmp_pm_ioctl(node_id, IOCTL_SET_SD_TAPDELAY,
> > +			      PM_TAPDELAY_INPUT, tap_delay, NULL);
> > +	if (ret)
> > +		pr_err("Error setting Input Tap Delay\n");
> > +
> > +	return ret;
> > +}
> > +
> >  static const struct zynqmp_eemi_ops eemi_ops = {
> >  	.get_api_version = zynqmp_pm_get_api_version,
> >  	.get_chipid = zynqmp_pm_get_chipid,
> > @@ -687,6 +733,8 @@ static const struct zynqmp_eemi_ops eemi_ops = {
> >  	.set_requirement = zynqmp_pm_set_requirement,
> >  	.fpga_load = zynqmp_pm_fpga_load,
> >  	.fpga_get_status = zynqmp_pm_fpga_get_status,
> > +	.sdio_out_setphase = zynqmp_pm_sdio_out_setphase,
> > +	.sdio_in_setphase = zynqmp_pm_sdio_in_setphase,
> 
> Are these eemi APIs? You are using ioctl eemi api to set the delay.

Yes, I am making these eemi APIs and calling ioctl API from these. This is to make the SD driver code more readable.

Thanks,
Manish