linux-kernel - RE: [PATCH V2] soc: imx-scu: Add SoC UID(unique identifier) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB3916DE79C32C23A8C3C11280F5F80@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Tue, 2 Jul 2019 07:51:00 +0000
From:   Anson Huang <anson.huang@....com>
To:     Marco Felsch <m.felsch@...gutronix.de>
CC:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        Aisheng Dong <aisheng.dong@....com>,
        Abel Vesa <abel.vesa@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V2] soc: imx-scu: Add SoC UID(unique identifier) support

Hi, Marco

> > > +	hdr->ver = IMX_SC_RPC_VERSION;
> > > +	hdr->svc = IMX_SC_RPC_SVC_MISC;
> > > +	hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID;
> > > +	hdr->size = 1;
> > > +
> > > +	/*
> > > +	 * SCU FW API always returns an error even the
> > > +	 * function is successfully executed, so skip
> > > +	 * returned value check.
> > > +	 */
> > > +	imx_scu_call_rpc(soc_ipc_handle, &msg, true);
> >
> > Please can you add a TODO: or FIXME: tag and also provide the firmware
> > version containing the bug? I know that developers are very busy and
> > follow- up fixes never reach mainline ;)
> 
> As I replied in previous mail, I will send out a V3 with below comment:
> 
> +       /*
> +        * SCU FW API does NOT have returned value for
> +        * this function, so skip returned value check.
> +        */
> +       imx_scu_call_rpc(soc_ipc_handle, &msg, true);
> 
> Thanks,
> Anson.

Sorry, after further thought, regarding for SCU API without response, we should
pass the "false" as imx_scu_call_rpc()'s 3rd parameter, so I will remove the comment
and use below in V3:

+       ret = imx_scu_call_rpc(soc_ipc_handle, &msg, false);
+       if (ret) {
+               pr_err("%s: get soc uid failed, ret %d\n", __func__, ret);
+               return ret;
+       }

Thanks,
Anson