linux-kernel - Re: [RFC V3 12/18] arm64: assembler: Add macro to annotate asm function having non standard stack-frame.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ddc9d27-e4ea-c07a-ad12-3fac59aeb4fc@arm.com>
Date:   Tue, 2 Jul 2019 10:49:30 +0100
From:   Raphael Gault <raphael.gault@....com>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        jpoimboe@...hat.com, peterz@...radead.org, will.deacon@....com,
        julien.thierry@....com
Subject: Re: [RFC V3 12/18] arm64: assembler: Add macro to annotate asm
 function having non standard stack-frame.

Hi,

On 7/1/19 3:40 PM, Catalin Marinas wrote:
> On Mon, Jun 24, 2019 at 10:55:42AM +0100, Raphael Gault wrote:
>> --- a/arch/arm64/include/asm/assembler.h
>> +++ b/arch/arm64/include/asm/assembler.h
>> @@ -752,4 +752,17 @@ USER(\label, ic	ivau, \tmp2)			// invalidate I line PoU
>>   .Lyield_out_\@ :
>>   	.endm
>>   
>> +	/*
>> +	 * This macro is the arm64 assembler equivalent of the
>> +	 * macro STACK_FRAME_NON_STANDARD define at
>> +	 * ~/include/linux/frame.h
>> +	 */
>> +	.macro	asm_stack_frame_non_standard	func
>> +#ifdef	CONFIG_STACK_VALIDATION
>> +	.pushsection ".discard.func_stack_frame_non_standard"
>> +	.8byte	\func
> 
> Nitpicks:
> 
> Does .quad vs .8byte make any difference?
> 

No it doesn't, I'll use .quad then.

> Could we place this in include/linux/frame.h directly with a generic
> name (and some __ASSEMBLY__ guards)? It doesn't look to be arm specific.
> 

It might be more consistent indeed, I'll do that.

Thanks,

-- 
Raphael Gault