linux-kernel - [PATCH] brcmfmac: Replace two seq_printf() calls in brcmf_feat_fwcap_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d96085a-76e8-c290-698a-e1473d3f4be7@web.de>
Date:   Tue, 2 Jul 2019 11:50:10 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        brcm80211-dev-list@...ress.com,
        brcm80211-dev-list.pdl@...adcom.com,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
        "David S. Miller" <davem@...emloft.net>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>,
        Rafał Miłecki <rafal@...ecki.pl>,
        Wright Feng <wright.feng@...ress.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH] brcmfmac: Replace two seq_printf() calls in
 brcmf_feat_fwcap_debugfs_read()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Tue, 2 Jul 2019 11:31:07 +0200

A line break and a single string should be put into a sequence.
Thus use the corresponding output functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
index 73aff4e4039d..ec0e80296e43 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
@@ -225,10 +225,10 @@ static int brcmf_feat_fwcap_debugfs_read(struct seq_file *seq, void *data)
 	}

 	/* Usually there is a space at the end of capabilities string */
-	seq_printf(seq, "%s", caps);
+	seq_puts(seq, caps);
 	/* So make sure we don't print two line breaks */
 	if (tmp > caps && *(tmp - 1) != '\n')
-		seq_printf(seq, "\n");
+		seq_putc(seq, '\n');

 	return 0;
 }
--
2.22.0