linux-kernel - Re: [PATCH] proc/sysctl: add shared variables for range check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Jul 2019 20:12:48 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     mcroce@...hat.com
Cc:     linux-kernel@...r.kernel.org, keescook@...omium.org,
        atomlin@...hat.com, akpm@...ux-foundation.org
Subject: Re: [PATCH] proc/sysctl: add shared variables for range check

> -static long zero;
>  static long long_max = LONG_MAX;
> 
>  struct ctl_table epoll_table[] = {
> @@ -301,7 +300,7 @@ struct ctl_table epoll_table[] = {
>                 .maxlen         = sizeof(max_user_watches),
>                 .mode           = 0644,
>                 .proc_handler   = proc_doulongvec_minmax,
> -               .extra1         = &zero,
> +               .extra1         = SYSCTL_ZERO,
>                 .extra2         = &long_max,

This looks wrong: proc_doulongvec_minmax() expects "long"s.
The whole patch needs rechecking.

> +/* shared constants to be used in various sysctls */
> +const =======>int<========== sysctl_vals[] = { 0, 1, INT_MAX };
> +EXPORT_SYMBOL(sysctl_vals);