linux-kernel - Re: [PATCH] selftests/x86/fsgsbase: Fix some test case bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <77F4123B-C10E-4EC0-AD2B-F7F3223BA3BA@intel.com>
Date:   Wed, 3 Jul 2019 00:20:49 +0000
From:   "Bae, Chang Seok" <chang.seok.bae@...el.com>
To:     Andy Lutomirski <luto@...nel.org>
CC:     LKML <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>, Borislav Petkov <bp@...en8.de>,
        Peter Zijlstra <peterz@...radead.org>,
        "H . Peter Anvin" <hpa@...or.com>, Andi Kleen <ak@...ux.intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>
Subject: Re: [PATCH] selftests/x86/fsgsbase: Fix some test case bugs


> On Jul 2, 2019, at 14:38, Andy Lutomirski <luto@...nel.org> wrote:
> 
> @@ -494,16 +489,24 @@ static void test_ptrace_write_gsbase(void)
> 		 * selector value is changed or not by the GSBASE write in
> 		 * a ptracer.
> 		 */
> -		if (gs != 0x7) {
> +		if (gs != *shared_scratch) {
> 			nerrs++;
> 			printf("[FAIL]\tGS changed to %lx\n", gs);

There is one more point to be fixed like this.
So, this diff also needs to be applied:

diff --git a/tools/testing/selftests/x86/fsgsbase.c b/tools/testing/selftests/x86/fsgsbase.c
index de8c80a..c9da4c5 100644
--- a/tools/testing/selftests/x86/fsgsbase.c
+++ b/tools/testing/selftests/x86/fsgsbase.c
@@ -472,7 +472,7 @@ static void test_ptrace_write_gsbase(void)
 
                gs = ptrace(PTRACE_PEEKUSER, child, gs_offset, NULL);
 
-               if (gs != 0x7) {
+               if (gs != *shared_scratch) {
                        nerrs++;
                        printf("[FAIL]\tGS is not prepared with nonzero\n");
                        goto END;

Thanks for the cleanup & the fix!