linux-kernel - Re: [PATCH v6 1/6] ARM: Add TTBR operator for kasan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Jul 2019 23:03:50 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Russell King <rmk+kernel@...linux.org.uk>
Cc:     Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Abbott Liu <liuwenliang@...wei.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Russell King <linux@...linux.org.uk>, christoffer.dall@....com,
        Marc Zyngier <marc.zyngier@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Nicolas Pitre <nico@...xnic.net>,
        Vladimir Murzin <vladimir.murzin@....com>,
        Kees Cook <keescook@...omium.org>, jinb.park7@...il.com,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Rob Landley <rob@...dley.net>,
        Greg KH <gregkh@...uxfoundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Thomas Gleixner <tglx@...utronix.de>, thgarnie@...gle.com,
        David Howells <dhowells@...hat.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Andre Przywara <andre.przywara@....com>,
        julien.thierry@....com, drjones@...hat.com, philip@....systems,
        mhocko@...e.com, kirill.shutemov@...ux.intel.com,
        kasan-dev@...glegroups.com,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kvmarm@...ts.cs.columbia.edu,
        Andrey Ryabinin <ryabinin.a.a@...il.com>
Subject: Re: [PATCH v6 1/6] ARM: Add TTBR operator for kasan_init

Hi Florian!

thanks for your patch!

On Tue, Jun 18, 2019 at 12:11 AM Florian Fainelli <f.fainelli@...il.com> wrote:

> From: Abbott Liu <liuwenliang@...wei.com>
>
> The purpose of this patch is to provide set_ttbr0/get_ttbr0 to
> kasan_init function. The definitions of cp15 registers should be in
> arch/arm/include/asm/cp15.h rather than arch/arm/include/asm/kvm_hyp.h,
> so move them.
>
> Cc: Andrey Ryabinin <aryabinin@...tuozzo.com>
> Reported-by: Marc Zyngier <marc.zyngier@....com>
> Signed-off-by: Abbott Liu <liuwenliang@...wei.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

> +#include <linux/stringify.h>

What is this for? I think it can be dropped.

This stuff adding a whole bunch of accessors:

> +static inline void set_par(u64 val)
> +{
> +       if (IS_ENABLED(CONFIG_ARM_LPAE))
> +               write_sysreg(val, PAR_64);
> +       else
> +               write_sysreg(val, PAR_32);
> +}

Can we put that in a separate patch since it is not
adding any users, so this is a pure refactoring patch for
the current code?

Yours,
Linus Walleij