linux-kernel - Re: [PATCH v6 2/6] ARM: Disable instrumentation for some code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdb3P6oQTK9FGUkMj4kax8us3rKH6c36pX=HD1_wMqcoJQ@mail.gmail.com>
Date:   Tue, 2 Jul 2019 23:56:38 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Abbott Liu <liuwenliang@...wei.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Russell King <linux@...linux.org.uk>, christoffer.dall@....com,
        Marc Zyngier <marc.zyngier@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Nicolas Pitre <nico@...xnic.net>,
        Vladimir Murzin <vladimir.murzin@....com>,
        Kees Cook <keescook@...omium.org>, jinb.park7@...il.com,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Rob Landley <rob@...dley.net>,
        Greg KH <gregkh@...uxfoundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Thomas Gleixner <tglx@...utronix.de>, thgarnie@...gle.com,
        David Howells <dhowells@...hat.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Andre Przywara <andre.przywara@....com>,
        julien.thierry@....com, drjones@...hat.com, philip@....systems,
        mhocko@...e.com, kirill.shutemov@...ux.intel.com,
        kasan-dev@...glegroups.com,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kvmarm@...ts.cs.columbia.edu,
        Andrey Ryabinin <ryabinin.a.a@...il.com>
Subject: Re: [PATCH v6 2/6] ARM: Disable instrumentation for some code

On Tue, Jun 18, 2019 at 12:11 AM Florian Fainelli <f.fainelli@...il.com> wrote:

> @@ -236,7 +236,8 @@ static int unwind_pop_register(struct unwind_ctrl_block *ctrl,
>                 if (*vsp >= (unsigned long *)ctrl->sp_high)
>                         return -URC_FAILURE;
>
> -       ctrl->vrs[reg] = *(*vsp)++;
> +       ctrl->vrs[reg] = READ_ONCE_NOCHECK(*(*vsp));
> +       (*vsp)++;

I would probably even put in a comment here so it is clear why we
do this. Passers-by may not know that READ_ONCE_NOCHECK() is
even related to KASan.

Other than that,
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij