linux-kernel - Re: [PATCH] net: pci: Fix hotplug event timeout with shpchp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <fdbaef22bd774ee49fc58fe13a76bf91@huawei.com>
Date:   Wed, 3 Jul 2019 02:07:51 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
CC:     "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "sebott@...ux.ibm.com" <sebott@...ux.ibm.com>,
        "lukas@...ner.de" <lukas@...ner.de>,
        "gustavo@...eddedor.com" <gustavo@...eddedor.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mingfangsen <mingfangsen@...wei.com>
Subject: Re: [PATCH] net: pci: Fix hotplug event timeout with shpchp


On Tue, Jul 02, 2019 at 01:35:19PM +0000, Miaohe Lin wrote:
> > Hotplug a network card would take more than 5 seconds in qemu + shpchp 
> > scene. It’s because 5 seconds delayed_work in func 
>
> I'm dropping this because of the required delay pointed out by Lukas.
>
> If you think we still need to do something here, please clarify the situation.  Are you hot-adding?  Hot-swapping?  Since you mention a protocol timeout, I suspect the latter, e.g., maybe you had an existing device with connections already open, and you want to replace it with a new device
> We do have to preserve the existing user experience, e.g., delays to allow operators to recover from mistaken latch opens or button presses.  But if we knew more about what you're trying to do, maybe we could figure out another approach.

Thanks for your reply. As is spec required, we would try to work around it.
Many thanks.

Have a good day.
Best wishes.