linux-kernel - Re: [PATCH 02/30] powerpc: Use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80d073af-f7b5-6c9d-de51-110f14d15380@c-s.fr>
Date:   Wed, 3 Jul 2019 15:19:26 +0200
From:   Christophe Leroy <christophe.leroy@....fr>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 02/30] powerpc: Use kmemdup rather than duplicating its
 implementation



Le 03/07/2019 à 15:13, Fuqian Huang a écrit :
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memset, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.

s/memset/memcpy/

> 
> Add an allocation failure check.

Shouldn't this be in another patch ?

Christophe

> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> ---
>   arch/powerpc/platforms/pseries/dlpar.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
> index 437a74173db2..20fe7b79e09e 100644
> --- a/arch/powerpc/platforms/pseries/dlpar.c
> +++ b/arch/powerpc/platforms/pseries/dlpar.c
> @@ -383,9 +383,10 @@ void queue_hotplug_event(struct pseries_hp_errorlog *hp_errlog)
>   	struct pseries_hp_work *work;
>   	struct pseries_hp_errorlog *hp_errlog_copy;
>   
> -	hp_errlog_copy = kmalloc(sizeof(struct pseries_hp_errorlog),
> +	hp_errlog_copy = kmemdup(hp_errlog, sizeof(struct pseries_hp_errorlog),
>   				 GFP_KERNEL);
> -	memcpy(hp_errlog_copy, hp_errlog, sizeof(struct pseries_hp_errorlog));
> +	if (!hp_errlog_copy)
> +		return;
>   
>   	work = kmalloc(sizeof(struct pseries_hp_work), GFP_KERNEL);
>   	if (work) {
>