linux-kernel - Re: [PATCH 09/30] macintosh: Use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d8ef6578-d879-9222-3feb-92264b8275ec@c-s.fr>
Date:   Wed, 3 Jul 2019 15:19:59 +0200
From:   Christophe Leroy <christophe.leroy@....fr>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/30] macintosh: Use kmemdup rather than duplicating its
 implementation



Le 03/07/2019 à 15:14, Fuqian Huang a écrit :
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memset, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.

s/memset/memcpy/

> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> ---
>   drivers/macintosh/adbhid.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/macintosh/adbhid.c b/drivers/macintosh/adbhid.c
> index 75482eeab2c4..5d14bebfb58f 100644
> --- a/drivers/macintosh/adbhid.c
> +++ b/drivers/macintosh/adbhid.c
> @@ -789,7 +789,8 @@ adbhid_input_register(int id, int default_id, int original_handler_id,
>   
>   	switch (default_id) {
>   	case ADB_KEYBOARD:
> -		hid->keycode = kmalloc(sizeof(adb_to_linux_keycodes), GFP_KERNEL);
> +		hid->keycode = kmemdup(adb_to_linux_keycodes,
> +			sizeof(adb_to_linux_keycodes), GFP_KERNEL);
>   		if (!hid->keycode) {
>   			err = -ENOMEM;
>   			goto fail;
> @@ -797,8 +798,6 @@ adbhid_input_register(int id, int default_id, int original_handler_id,
>   
>   		sprintf(hid->name, "ADB keyboard");
>   
> -		memcpy(hid->keycode, adb_to_linux_keycodes, sizeof(adb_to_linux_keycodes));
> -
>   		switch (original_handler_id) {
>   		default:
>   			keyboard_type = "<unknown>";
>