linux-kernel - Re: [PATCH -next] integrity: Remove set but not used variable 'acl'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15691.1562162261@warthog.procyon.org.uk>
Date:   Wed, 03 Jul 2019 14:57:41 +0100
From:   David Howells <dhowells@...hat.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     dhowells@...hat.com, James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Kairui Song <kasong@...hat.com>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        Mimi Zohar <zohar@...ux.ibm.com>,
        "Thiago Jung Bauermann" <bauerman@...ux.ibm.com>,
        Nayna Jain <nayna@...ux.ibm.com>,
        "Eric Biggers" <ebiggers@...gle.com>,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] integrity: Remove set but not used variable 'acl'

YueHaibing <yuehaibing@...wei.com> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> security/integrity/digsig.c: In function 'integrity_init_keyring':
> security/integrity/digsig.c:99:18: warning:
>  variable 'acl' set but not used [-Wunused-but-set-variable]
> 
> It seems 'acl' is needed in __integrity_init_keyring

I've folded this fix in, thanks.

David